Update README.md #69
Open
Update README.md #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from [elixir 1.4 documentation](https://elixir-lang.org/blog/2017/01/05/elixir-v1-4-0-released/), Mix v1.4 now automatically infers your applications list as long as you leave the `:applications` key empty. So we should put an explanation for people who use more than version 1.4. Everything works well.
zhyu
requested changes
May 28, 2018
| @@ -48,7 +48,7 @@ config :nadia, | |||
| ``` | |||
|
|
|||
| And then, in `mix.exs`, list `:nadia` as an application inside `application/0`: | |||
|
|
|||
| (you can omit this if your elixir is >= 1.4) | |||
There was a problem hiding this comment.
I think we could use more explanation here, e.g.,
"you can leave the applications key empty to use application inference if your elixir is >= 1.4"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from elixir 1.4 documentation, Mix v1.4 now automatically infers your applications list as long as you leave the
:applicationskey empty. So we should put an explanation for people who use more than version 1.4. Everything works well.